feat(api-service): implement multi subscription with condition to topic fixes NV-6810 #9370

djabarovgeorge · 2025-10-20T07:51:12Z

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

…ions - Introduced resourceConditions and subscriberConditions in the topic subscriptions feature to allow conditional notifications based on JSONLogic rules. - Added a new EvaluateSubscriptionConditions use case to evaluate these conditions. - Updated relevant DTOs and repositories to support the new fields and logic. - Included a condition hash for efficient subscription management. - Added json-logic-js as a dependency for condition evaluation.

linear · 2025-10-20T07:51:14Z

NV-6810 Implement multi subscription with condition to topic

netlify · 2025-10-20T07:51:17Z

❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

Name	Link
🔨 Latest commit	`d217453`
🔍 Latest deploy log	https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/68fa382dff8d3300082a67f0

… condition field

…te repository methods - Renamed 'condition' to 'conditions' across various DTOs and use cases for consistency. - Updated the TopicSubscribersRepository to implement a new method for bulk subscription creation, returning detailed results for created, updated, and failed subscriptions. - Removed the EvaluateSubscriptionConditions use case as its functionality has been integrated into the TriggerMulticast use case. - Adjusted related logic to accommodate the new structure for conditions.

…ndition-to-topic

blacksmith-sh · 2025-10-20T13:34:50Z

1 Job Failed:

Check pull request / Find LaunchDarkly feature flags in diff failed on "Find flags"

  > Run launchdarkly/find-code-references-in-pull-request@v2
  with:
    project-key: default
    environment-key: production
    access-token: ***
    repo-token: ***
    placeholder-comment: false
    include-archived-flags: true
    max-flags: 5
    base-uri: https://app.launchdarkly.com
    check-extinctions: true
    create-flag-links: true
  env:
    NX_CLOUD_ACCESS_TOKEN: ***
    GITHUB_REPO_NAME: novuhq/novu

2025/10/20 17:43:04 unexpected status code: 503. unable to parse response: EOF
Error: unexpected status code: 503. unable to parse response: EOF

Summary: 3 successful workflows, 1 failed workflow

✅ Check for .only flags (1 job succeeded)
✅ CodeQL (2 jobs succeeded)
✅ Validate Submodule Sync (2 jobs succeeded)
❌ Check pull request (11 jobs succeeded, 1 job failed, 1 job cancelled)

Last updated: 2025-10-20 17:58:34 UTC

…on evaluation

djabarovgeorge · 2025-10-20T14:07:21Z

.../src/app/topics-v2/usecases/create-topic-subscriptions/create-topic-subscriptions.usecase.ts

+    if (conditionHash !== undefined) {
+      existingSubscriptionsQuery.conditionHash = conditionHash;
+    } else {
+      existingSubscriptionsQuery.$or = [{ conditionHash: { $exists: false } }, { conditionHash: null }];


validate if we ca use rooted $or

djabarovgeorge · 2025-10-20T14:08:08Z

libs/application-generic/src/usecases/trigger-multicast/trigger-multicast.usecase.ts

+        const passingSubscriptions = subscriptionsBatch.filter((subscription) => {
+          return this.evaluateConditions(
+            subscription.conditions as Record<string, unknown>,
+            { payload: command.payload } as Record<string, unknown>


here we will need to add workflow entity variable as well

djabarovgeorge · 2025-10-20T14:20:59Z

libs/dal/src/repositories/topic/topic-subscribers.repository.ts

+    const cursor = this._model
+      .find(
+        {
          _organizationId: this.convertStringToObjectId(_organizationId),
          _environmentId: this.convertStringToObjectId(_environmentId),
          _topicId: { $in: mappedTopicIds },
          externalSubscriberId: { $nin: excludeSubscribers },
        },
-      },
-      {
-        $group: {
-          _id: '$externalSubscriberId',
-          topics: { $push: '$_topicId' },
-        },
-      },
-    ];
+        {
+          externalSubscriberId: 1,
+          conditions: 1,
+        }
+      )
+      .cursor({ batchSize });


the missing grouping by subscriber id could couse more copute, because we could fetch duplicated subscribers, however we still need them because 1 subscriber could pass the condition while the other will not.

- Enhanced the topic subscriptions feature by introducing a new workflows field in the relevant DTOs and use cases. - Updated the TopicsController to handle workflows in subscription requests. - Modified the CreateTopicSubscriptions use case to process and store workflows associated with subscriptions. - Added validation and transformation logic for workflows in the DTOs. - Updated end-to-end tests to verify the correct handling of workflows in subscription creation.

djabarovgeorge temporarily deployed to Linting October 20, 2025 07:51 — with GitHub Actions Inactive

github-actions bot added @novu/dal @novu/api-service labels Oct 20, 2025

github-actions bot changed the title ~~feat(api): add resource and subscriber conditions for topic subscript…~~ feat(api): add resource and subscriber conditions for topic subscript… fixes NV-6810 Oct 20, 2025

djabarovgeorge changed the title ~~feat(api): add resource and subscriber conditions for topic subscript… fixes NV-6810~~ feat(api-service): implement multi subscription with condition to topic Oct 20, 2025

github-actions bot changed the title ~~feat(api-service): implement multi subscription with condition to topic~~ feat(api-service): implement multi subscription with condition to topic fixes NV-6810 Oct 20, 2025

refactor(api): rename resource and subscriber conditions to a unified…

be18246

… condition field

djabarovgeorge temporarily deployed to Linting October 20, 2025 08:37 — with GitHub Actions Inactive

djabarovgeorge had a problem deploying to Linting October 20, 2025 13:17 — with GitHub Actions Error

Merge branch 'next' into nv-6810-implement-multi-subscription-with-co…

c2cc377

…ndition-to-topic

djabarovgeorge temporarily deployed to Linting October 20, 2025 13:18 — with GitHub Actions Inactive

djabarovgeorge had a problem deploying to Linting October 20, 2025 13:18 — with GitHub Actions Failure

djabarovgeorge temporarily deployed to Linting October 20, 2025 13:18 — with GitHub Actions Inactive

fix(trigger-multicast): wrap command payload in an object for conditi…

9c48297

…on evaluation

djabarovgeorge had a problem deploying to Linting October 20, 2025 14:05 — with GitHub Actions Failure

djabarovgeorge temporarily deployed to Linting October 20, 2025 14:05 — with GitHub Actions Inactive

djabarovgeorge commented Oct 20, 2025

View reviewed changes

refactor(api): polish

d8cc55b

djabarovgeorge had a problem deploying to Linting October 20, 2025 14:16 — with GitHub Actions Failure

djabarovgeorge temporarily deployed to Linting October 20, 2025 14:16 — with GitHub Actions Inactive

djabarovgeorge commented Oct 20, 2025

View reviewed changes

djabarovgeorge marked this pull request as ready for review October 20, 2025 14:21

djabarovgeorge had a problem deploying to Linting October 20, 2025 17:42 — with GitHub Actions Failure

djabarovgeorge added 4 commits October 22, 2025 19:32

feat(api-servide): add test

ca1aef6

refactor(api): enhance condition hashing for topic subscriptions

2288c24

feat(api): add conditional delivery test for topic subscriptions

d217453

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(api-service): implement multi subscription with condition to topic fixes NV-6810 #9370

feat(api-service): implement multi subscription with condition to topic fixes NV-6810 #9370

djabarovgeorge commented Oct 20, 2025

Uh oh!

linear bot commented Oct 20, 2025

Uh oh!

netlify bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

blacksmith-sh bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

djabarovgeorge Oct 20, 2025

Uh oh!

djabarovgeorge Oct 20, 2025

Uh oh!

djabarovgeorge Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat(api-service): implement multi subscription with condition to topic fixes NV-6810 #9370

Are you sure you want to change the base?

feat(api-service): implement multi subscription with condition to topic fixes NV-6810 #9370

Conversation

djabarovgeorge commented Oct 20, 2025

What changed? Why was the change needed?

Screenshots

Related enterprise PR

Special notes for your reviewer

Uh oh!

linear bot commented Oct 20, 2025

Uh oh!

netlify bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

Uh oh!

blacksmith-sh bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

djabarovgeorge Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

djabarovgeorge Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

djabarovgeorge Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

netlify bot commented Oct 20, 2025 •

edited

Loading

blacksmith-sh bot commented Oct 20, 2025 •

edited

Loading